-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
module: force require('process') to return a reference to process #206
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Why not |
@vkurchatkin there were a few ways to do this... making |
I prefer the lib/process.js approach. Anything that doesn't require hacking lib/module.js. |
@bnoordhuis added |
@@ -0,0 +1,25 @@ | |||
// Copyright Joyent, Inc. and other Node contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to either // Copyright io.js contributors
or your own / your company's name?
LGTM technically but as the discussion in #157 doesn't appear to have reached a conclusion, I won't merge it straight away. I'll bring it up at the next TC meeting unless enough TC members +1 it before that. |
Happy holidays everyone! |
@lxe Still one nit but if you fix that, I'll land it. Thanks. |
This makes require('process') always return a reference to the global process object.
@bnoordhuis totally missed that one! Thanks. |
This makes require('process') always return a reference to the global process object. PR-URL: #206 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Cheers Aleksey, landed in d8586ea. I had to reword the first line to make it fit in 50 columns. Thanks! |
Great stuff @bnoordhuis. thank you! |
ftr, agreed to merge this in TC meeting 2014-12-30 #229 |
This makes require('process') always return a reference to the global process object. Fixes #157