test: string-decorater.lastChar #21084
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test for string-decorater.lastChar to improve coverage.
TimothyGu
approved these changes
Jun 1, 2018
lance
approved these changes
Jun 1, 2018
trivikr
approved these changes
Jun 3, 2018
test/parallel/test-string-decoder.js
Outdated
| @@ -90,7 +90,8 @@ test('utf16le', Buffer.from('3DD84DDC', 'hex'), '\ud83d\udc4d'); // thumbs up | |||
| decoder = new StringDecoder('utf8'); | |||
| assert.strictEqual(decoder.write(Buffer.from('E1', 'hex')), ''); | |||
|
|
|||
| // A quick test for lastNeed & lastTotal which are undocumented. | |||
| // A quick test for lastChar & lastNeed & lastTotal which are undocumented. | |||
There was a problem hiding this comment.
nit: lastChar & lastNeed & lastTotal -> lastChar, lastNeed & lastTotal
trivikr
approved these changes
Jun 4, 2018
trivikr
added
the
author ready
lance
pushed a commit
that referenced
this pull request
Jun 4, 2018
Added test for string-decorater.lastChar to improve coverage. PR-URL: #21084 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in: 42adb65 |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
Added test for string-decorater.lastChar to improve coverage. PR-URL: #21084 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for string-decorater.lastChar to improve coverage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes