Revert "workers,trace_events: set thread name for workers" #21362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a24b691.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/15487/ 👍 here for fast-tracking |
devsnek
approved these changes
Jun 15, 2018
2 tasks
|
I'm going with James'es #21363 |
|
Reverted in #21363 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a24b691.
The reverted commit was landed about 7 hours ago despite that it added a test that fails reliably on Windows. CI has been red ever since.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes