Skip to content

test: fix parallel/test-tls-env-extra-ca.js #21647

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: fix parallel/test-tls-env-extra-ca.js #21647

wants to merge 1 commit into from

Conversation

Niicck
Copy link
Contributor

@Niicck Niicck commented Jul 4, 2018

fix args in final assert.strictEqual() call

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines

@Niicck
test: fix parallel/test-tls-env-extra-ca.js
6f772eb 
fix args in final assert.strictEqual() call
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 4, 2018
@Trott
Copy link
Member

Trott commented Jul 4, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15721/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2018
trivikr pushed a commit that referenced this pull request Jul 10, 2018
@Niicck @trivikr
test: fix parallel/test-tls-env-extra-ca.js
d0b00a7 
fix args in final assert.strictEqual() call

PR-URL: #21647
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@trivikr
Copy link
Member

trivikr commented Jul 10, 2018

Landed in d0b00a7

Congratulations @Niicck on your first commit in Node.js core! 🎉🎉🎉

@trivikr trivikr closed this Jul 10, 2018
targos pushed a commit that referenced this pull request Jul 10, 2018
@Niicck @targos
test: fix parallel/test-tls-env-extra-ca.js
11e9b4e 
fix args in final assert.strictEqual() call

PR-URL: #21647
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@JungMinu JungMinu JungMinu approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Niicck @Trott @trivikr @lpinca @cjihrig @JungMinu @nodejs-github-bot