test: remove custom AsyncHooksTestConfiguration #22008
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has the same behavior as `ParallelTestConfiguration`
nodejs-github-bot
added
async_hooks
Trott
approved these changes
Jul 28, 2018
BridgeAR
approved these changes
Jul 29, 2018
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16053/ (edit @maclover7: ✔️) |
maclover7
added
the
author ready
|
Landed in 3a056c0 |
maclover7
added a commit
that referenced
this pull request
Jul 31, 2018
Has the same behavior as `ParallelTestConfiguration` PR-URL: #22008 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2018
Has the same behavior as `ParallelTestConfiguration` PR-URL: #22008 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced Aug 1, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has the same behavior as
ParallelTestConfiguration, so switch to using that :)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes