src: encode 0x27 (') for special URLs #22022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
targos
approved these changes
Jul 30, 2018
mscdex
reviewed
Jul 30, 2018
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| /* The following tests are copied from WPT. Modifications to them should be | |||
| upstreamed first. Refs: | |||
| https://github.com/w3c/web-platform-tests/blob/88b75886e/url/urltestdata.json | |||
| https://github.com/web-platform-tests/wpt/blob/ba4921d054808a44c2966507c19861ca729a76a2/url/resources/urltestdata.json | |||
There was a problem hiding this comment.
Minor nit: perhaps we could make this URL at least a little shorter by reducing the length of the commit/tree hash?
cjihrig
approved these changes
Jul 30, 2018
jasnell
approved these changes
Jul 30, 2018
BridgeAR
approved these changes
Jul 30, 2018
lpinca
approved these changes
Jul 30, 2018
maclover7
added
the
author ready
|
New CI (since the previous results are not accessible): https://ci.nodejs.org/job/node-test-pull-request/16382/ |
|
Running linux-containered CI again: https://ci.nodejs.org/job/node-test-commit-linux-containered/6196/ |
|
@nodejs/build ... linux-containered buildbot is having some issue here: |
On it. Seems to be some issue with EOL characters on |
|
Landed in c7788fb. |
TimothyGu
added a commit
that referenced
this pull request
Aug 18, 2018
Refs: whatwg/url@6ef17eb PR-URL: #22022 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2018
Refs: whatwg/url@6ef17eb PR-URL: #22022 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Refs: whatwg/url@6ef17eb PR-URL: #22022 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 6, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: whatwg/url@6ef17eb
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes