os: move process.binding('os') to internalBinding

lib/internal/bootstrap/node.js

@@ -359,7 +359,8 @@
         'contextify',
         'tcp_wrap',
         'tls_wrap',
-        'async_wrap']);
+        'async_wrap',
+        'os']);
     process.binding = function binding(name) {
       return internalBindingWhitelist.has(name) ?
         internalBinding(name) :

lib/os.js

@@ -24,6 +24,7 @@
 const { pushValToArrayMax, safeGetenv } = process.binding('util');
 const constants = process.binding('constants').os;
 const { deprecate } = require('internal/util');
+const { internalBinding } = require('internal/bootstrap/loaders');
 const isWindows = process.platform === 'win32';
 
 const { codes: { ERR_SYSTEM_ERROR } } = require('internal/errors');
@@ -44,7 +45,7 @@ const {
   getUptime,
   isBigEndian,
   setPriority: _setPriority
-} = process.binding('os');
+} = internalBinding('os');
 
 function getCheckedFunction(fn) {
   return function checkError(...args) {

src/node_os.cc

@@ -470,4 +470,4 @@ void Initialize(Local<Object> target,
 }  // namespace os
 }  // namespace node
 
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(os, node::os::Initialize)
+NODE_MODULE_CONTEXT_AWARE_INTERNAL(os, node::os::Initialize)

test/parallel/test-os-checked-function.js

@@ -1,7 +1,11 @@
+// Flags: --expose-internals
 'use strict';
+
+const { internalBinding } = require('internal/test/binding');
+
 // Monkey patch the os binding before requiring any other modules, including
 // common, which requires the os module.
-process.binding('os').getHomeDirectory = function(ctx) {
+internalBinding('os').getHomeDirectory = function(ctx) {
   ctx.syscall = 'foo';
   ctx.code = 'bar';
   ctx.message = 'baz';

test/parallel/test-process-binding-internalbinding-whitelist.js

@@ -12,3 +12,4 @@ assert(process.binding('v8'));
 assert(process.binding('stream_wrap'));
 assert(process.binding('signal_wrap'));
 assert(process.binding('contextify'));
+assert(process.binding('os'));