http2: move process.binding('http2') to internalBinding #22328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
semver-major
|
@jasnell sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
the
lib / src
33 tasks
cjihrig
approved these changes
Aug 15, 2018
trivikr
approved these changes
Aug 15, 2018
devsnek
approved these changes
Aug 15, 2018
Trott
approved these changes
Aug 15, 2018
jasnell
added
the
author ready
BridgeAR
approved these changes
Aug 17, 2018
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16528/ |
jasnell
force-pushed
the
http2-internal-binding
branch
from
e8089cf to
fe31b14
Compare
|
Trying CI again: https://ci.nodejs.org/job/node-test-pull-request/16539/ |
joyeecheung
approved these changes
Aug 18, 2018
jasnell
added a commit
that referenced
this pull request
Aug 18, 2018
Refs: #22160 PR-URL: #22328 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in 4fa5448 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #22160
The
http2module is still experimental.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes