tools: simplify ESLint invocation in Makefile #22348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Trott sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
build
|
(Because this is a lint change, lite-pipeline is probably sufficient CI.) |
TimothyGu
approved these changes
Aug 16, 2018
richardlau
approved these changes
Aug 16, 2018
|
Does anything equivalent need to be done to Line 598 in 16accff |
@richardlau No. It doesn't use the |
maclover7
approved these changes
Aug 16, 2018
BridgeAR
approved these changes
Aug 16, 2018
silverwind
approved these changes
Aug 16, 2018
cjihrig
approved these changes
Aug 16, 2018
jasnell
approved these changes
Aug 16, 2018
lpinca
approved these changes
Aug 16, 2018
BridgeAR
added
the
author ready
trivikr
approved these changes
Aug 17, 2018
|
Accidentally kicked off a full CI; might as well see it to its logical conclusion. CI: https://ci.nodejs.org/job/node-test-pull-request/16526/ |
|
Fix a problem on a bunch of CI hosts. Let's try again. CI: https://ci.nodejs.org/job/node-test-pull-request/16527/ |
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/16551/ |
Makefile currently enforces .eslintrc.js linting on the command line but it is already enforced in the .estlintignore file. This also simplifies an arguably-related comment in .estlinrc.js.
|
CI after rebase (to test if that fixes the whole jinja LICENSE issue that has been popping up on CI lately): https://ci.nodejs.org/job/node-test-pull-request/16552/ |
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16557/ |
|
Landed in c535bde |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 19, 2018
Makefile currently enforces .eslintrc.js linting on the command line but it is already enforced in the .estlintignore file. This also simplifies an arguably-related comment in .estlinrc.js. PR-URL: nodejs#22348 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2018
Makefile currently enforces .eslintrc.js linting on the command line but it is already enforced in the .estlintignore file. This also simplifies an arguably-related comment in .estlinrc.js. PR-URL: #22348 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Makefile currently enforces .eslintrc.js linting on the command line but it is already enforced in the .estlintignore file. This also simplifies an arguably-related comment in .estlinrc.js. PR-URL: #22348 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile currently enforces .eslintrc.js linting on the command line but
it is already enforced in the .estlintignore file.
This also simplifies an arguably-related comment in .estlinrc.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes