perf_hooks: move strings to env #22401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move repeatedly created strings to env
nodejs-github-bot
added
the
c++
devsnek
approved these changes
Aug 19, 2018
TimothyGu
approved these changes
Aug 19, 2018
cjihrig
approved these changes
Aug 20, 2018
addaleax
approved these changes
Aug 20, 2018
jasnell
added
the
author ready
|
Unrelated CI failures, resuming: https://ci.nodejs.org/job/node-test-pull-request/16637/ |
|
Resuming again because more unrelated CI failures: https://ci.nodejs.org/job/node-test-pull-request/16643/ |
|
Resuming again: https://ci.nodejs.org/job/node-test-pull-request/16660/ |
trivikr
approved these changes
Aug 22, 2018
jasnell
added a commit
that referenced
this pull request
Aug 22, 2018
Move repeatedly created strings to env PR-URL: #22401 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in 588fb05 |
targos
pushed a commit
that referenced
this pull request
Aug 24, 2018
Move repeatedly created strings to env PR-URL: #22401 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Move repeatedly created strings to env PR-URL: #22401 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move repeatedly created strings to env
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes