test: move common.ArrayStream to separate module #22447
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
approved these changes
Aug 21, 2018
cjihrig
approved these changes
Aug 22, 2018
trivikr
approved these changes
Aug 22, 2018
trivikr
reviewed
Aug 22, 2018
| @@ -413,6 +413,19 @@ Platform normalizes the `pwd` command. | |||
|
|
|||
| Synchronous version of `spawnPwd`. | |||
|
|
|||
| ## ArrayStream Module | |||
There was a problem hiding this comment.
Does arrayStream needs to be removed from line 41?
There was a problem hiding this comment.
Since that seemed self-evident, I went ahead and did it. Separate commit so if I'm wrong, it can be rebased out easily.
In a continuing effort to de-monolithize `require('../common')`,
move `common.ArrayStream` out to a separate module that is
imported only when it is needed.
jasnell
force-pushed
the
test-no-common-arraystream
branch
from
6ff0d5d to
4a82568
Compare
|
CI failed with infrastructure and lint issues.. trying yet again: https://ci.nodejs.org/job/node-test-pull-request/16682/ |
|
@nodejs/build ... linuxone build bot is failing consistently again. |
refack
approved these changes
Aug 22, 2018
Fixed - https://ci.nodejs.org/job/node-test-commit-linuxone/4284/ |
lpinca
approved these changes
Aug 22, 2018
jasnell
added
the
author ready
jasnell
added a commit
that referenced
this pull request
Aug 23, 2018
In a continuing effort to de-monolithize `require('../common')`,
move `common.ArrayStream` out to a separate module that is
imported only when it is needed.
PR-URL: #22447
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in fa543c0 |
targos
pushed a commit
that referenced
this pull request
Aug 24, 2018
In a continuing effort to de-monolithize `require('../common')`,
move `common.ArrayStream` out to a separate module that is
imported only when it is needed.
PR-URL: #22447
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
In a continuing effort to de-monolithize `require('../common')`,
move `common.ArrayStream` out to a separate module that is
imported only when it is needed.
PR-URL: #22447
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 6, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a continuing effort to de-monolithize
require('../common'),move
common.ArrayStreamout to a separate module that isimported only when it is needed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes