test: move hijackstdio out of require('common') #22462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
approved these changes
Aug 22, 2018
refack
approved these changes
Aug 22, 2018
trivikr
approved these changes
Aug 23, 2018
lpinca
approved these changes
Aug 23, 2018
| @@ -57,4 +62,4 @@ tests.forEach(function(test) { | |||
|
|
|||
| assert.strictEqual(process.stdout.writeTimes, tests.length); | |||
|
|
|||
| common.restoreStdout(); | |||
| restoreStdout(); | |||
There was a problem hiding this comment.
Unrelated but why isn't restoreStderr() also used?
There was a problem hiding this comment.
I remember signing off on this (#13439)... I want to say it's related to the mustNotCall mechanism?...
But it should have been docu-commented for future reference.
There was a problem hiding this comment.
Sounds like a good first issue #22472
jasnell
force-pushed
the
test-move-hijackstdio
branch
from
7bd43af to
0c8ad74
Compare
test/common/README.md
Outdated
| * `listener` [<Function>]: a listener with a single parameter | ||
| called `data`. | ||
|
|
||
| Eavesdrop to `process.stderr.write` calls. Once `process.stderr.write` is |
There was a problem hiding this comment.
Nit: maybe add parentheses to `process.stderr.write`, `process.stdout.write` and `write` function in all 4 sections.
Move the hijackstdio functions out of common so that they are imported only into the tests that actually need them
jasnell
force-pushed
the
test-move-hijackstdio
branch
from
72a28c9 to
f2af892
Compare
jasnell
added
the
author ready
|
Shouldn't the module be camelCased as |
jasnell
added a commit
that referenced
this pull request
Aug 24, 2018
Move the hijackstdio functions out of common so that they are imported only into the tests that actually need them PR-URL: #22462 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 5da834f |
addaleax
pushed a commit
that referenced
this pull request
Aug 27, 2018
Move the hijackstdio functions out of common so that they are imported only into the tests that actually need them PR-URL: #22462 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Move the hijackstdio functions out of common so that they are imported only into the tests that actually need them PR-URL: #22462 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Move the hijackstdio functions out of common so that they are imported only into the tests that actually need them PR-URL: #22462 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 6, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the hijackstdio functions out of common so that they are
imported only into the tests that actually need them
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes