test: remove string literal from strictEqual() #22512
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-stream2-writable.js to allow for debugging to work properly
addaleax
approved these changes
Aug 24, 2018
There was a problem hiding this comment.
Thanks! 🎉
If you want, have a look at the commit message guidelines, but that can also be taken care of when merging this.
jasnell
approved these changes
Aug 25, 2018
Trott
approved these changes
Aug 25, 2018
Trott
added
the
author ready
cjihrig
approved these changes
Aug 25, 2018
lpinca
approved these changes
Aug 25, 2018
ScottyVG
changed the title
trivikr
approved these changes
Aug 25, 2018
gdams
approved these changes
Aug 26, 2018
gdams
pushed a commit
that referenced
this pull request
Aug 27, 2018
Remove 3rd argument from assert.deepStrictEqual() in test/parallel/test-stream2-writable.js to allow for debugging to work properly. PR-URL: #22512 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 27, 2018
Remove 3rd argument from assert.deepStrictEqual() in test/parallel/test-stream2-writable.js to allow for debugging to work properly. PR-URL: #22512 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Remove 3rd argument from assert.deepStrictEqual() in test/parallel/test-stream2-writable.js to allow for debugging to work properly. PR-URL: #22512 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Remove 3rd argument from assert.deepStrictEqual() in test/parallel/test-stream2-writable.js to allow for debugging to work properly. PR-URL: #22512 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
This was referenced Sep 6, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st-stream2-writable.js to allow for debugging to work properly
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes