Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

n-api: remove idle_running from TsFn #22520

Closed
wants to merge 1 commit into from
Closed

n-api: remove idle_running from TsFn #22520

wants to merge 1 commit into from

Conversation

ralphtheninja
Copy link

@ralphtheninja ralphtheninja commented Aug 25, 2018 •
edited
Loading

The idle_running member variable in TsFn is always false and can
therefore be removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Aug 25, 2018
n-api: remove idle_running from TsFn
50e5a2d 
The idle_running member variable in TsFn is always false and can
therefore be removed.
@ralphtheninja ralphtheninja force-pushed the napi-remove-idle-running branch from c043d20 to 50e5a2d Compare August 25, 2018 11:16
@addaleax
Copy link
Member

I think this might have to be rebased after #22259 lands, as a heads up

@gabrielschulhof
Copy link
Contributor

@addaleax I'll land this first, then land mine with a rebase.

@gabrielschulhof
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/16762/

@gabrielschulhof
Copy link
Contributor

Another CI: https://ci.nodejs.org/job/node-test-pull-request/16773/

@ralphtheninja
Copy link
Author

Let me know if I should rebase it.

@gabrielschulhof
Copy link
Contributor

Another CI run: https://ci.nodejs.org/job/node-test-pull-request/16794/

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Aug 27, 2018 •
edited by addaleax
Loading

CI resumed as: https://ci.nodejs.org/job/node-test-pull-request/16799/ (:heavy_check_mark:)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2018
@gabrielschulhof
Copy link
Contributor

Landed in 5081d96.

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Aug 28, 2018
n-api: remove idle_running from TsFn
5081d96 
The idle_running member variable in TsFn is always false and can
therefore be removed.

PR-URL: nodejs#22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
@ralphtheninja ralphtheninja deleted the napi-remove-idle-running branch August 28, 2018 12:20
addaleax pushed a commit that referenced this pull request Aug 28, 2018
@addaleax
n-api: remove idle_running from TsFn
698e90c 
The idle_running member variable in TsFn is always false and can
therefore be removed.

PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 3, 2018
@targos
n-api: remove idle_running from TsFn
609ae33 
The idle_running member variable in TsFn is always false and can
therefore be removed.

PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@targos
n-api: remove idle_running from TsFn
8eae030 
The idle_running member variable in TsFn is always false and can
therefore be removed.

PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
This was referenced Sep 6, 2018
Closed
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2018
n-api: remove idle_running from TsFn
46118be 
The idle_running member variable in TsFn is always false and can
therefore be removed.

PR-URL: nodejs#22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins pushed a commit that referenced this pull request Jan 18, 2019
@MylesBorins
n-api: remove idle_running from TsFn
311e1f1 
The idle_running member variable in TsFn is always false and can
therefore be removed.

Backport-PR-URL: #25002
PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
n-api: remove idle_running from TsFn
09b88aa 
The idle_running member variable in TsFn is always false and can
therefore be removed.

Backport-PR-URL: #25002
PR-URL: #22520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Gus Caplan <me@gus.host>
@MylesBorins MylesBorins mentioned this pull request Mar 26, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ralphtheninja @addaleax @gabrielschulhof @jasnell @devsnek @nodejs-github-bot