Skip to content

[v10.x] src: backport programmatically accessible CLI options #22644

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v10.x] src: backport programmatically accessible CLI options #22644

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 1, 2018 •
edited
Loading

The only conflicts are two more changed lines for --expose-http2 in the first commit and a neighbouring-line conflict in node.gyp in the second commit.

(Backports #22490)

@addaleax
src: make CLI options programatically accesible
e0d517e 
Provide `internalBinding('options')` with some utilities
around making the options parser and current options values
programatically accessible.

PR-URL: nodejs#22490
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@addaleax
cli: generate --help text in JS
dfbf040 
Instead of having a custom, static, hand-written string
that is being printed to stdout when `--help` is present,
generate it in JS when requested.

PR-URL: nodejs#22490
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/761/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v10.x labels Sep 1, 2018
@addaleax
Copy link
Member Author

addaleax commented Sep 1, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16923/

@addaleax
Copy link
Member Author

addaleax commented Sep 2, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/16957/

targos pushed a commit that referenced this pull request Sep 2, 2018
@addaleax @targos
src: make CLI options programatically accesible
afea168 
Provide `internalBinding('options')` with some utilities
around making the options parser and current options values
programatically accessible.

Backport-PR-URL: #22644
PR-URL: #22490
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Sep 2, 2018
@addaleax @targos
cli: generate --help text in JS
58e90a2 
Instead of having a custom, static, hand-written string
that is being printed to stdout when `--help` is present,
generate it in JS when requested.

Backport-PR-URL: #22644
PR-URL: #22490
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Sep 2, 2018

Landed in afea168 and 58e90a2

@targos targos closed this Sep 2, 2018
targos pushed a commit that referenced this pull request Sep 3, 2018
@addaleax @targos
src: make CLI options programatically accesible
b829958 
Provide `internalBinding('options')` with some utilities
around making the options parser and current options values
programatically accessible.

Backport-PR-URL: #22644
PR-URL: #22490
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@addaleax @targos
cli: generate --help text in JS
18ce2b8 
Instead of having a custom, static, hand-written string
that is being printed to stdout when `--help` is present,
generate it in JS when requested.

Backport-PR-URL: #22644
PR-URL: #22490
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2018
@addaleax @targos
src: make CLI options programatically accesible
b0ea867 
Provide `internalBinding('options')` with some utilities
around making the options parser and current options values
programatically accessible.

Backport-PR-URL: #22644
PR-URL: #22490
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2018
@addaleax @targos
cli: generate --help text in JS
cab8a0b 
Instead of having a custom, static, hand-written string
that is being printed to stdout when `--help` is present,
generate it in JS when requested.

Backport-PR-URL: #22644
PR-URL: #22490
Reviewed-By: Michaël Zasso <targos@protonmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@targos targos targos approved these changes

@mihalskiy mihalskiy mihalskiy approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @targos @mihalskiy