src: remove calls to deprecated V8 functions (Equals) #22665
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
I’d slightly prefer using |
|
Sure, I somehow thought it was a method of the String class ^^ |
Remove all calls to deprecated V8 functions (here: Value::Equals) inside the code.
targos
force-pushed
the
deprecated-equals
branch
from
a6b1c93 to
9a76224
Compare
|
Done! CI: https://ci.nodejs.org/job/node-test-pull-request/16969/ (:heavy_check_mark:) |
addaleax
approved these changes
Sep 2, 2018
danbev
approved these changes
Sep 3, 2018
ryzokuken
approved these changes
Sep 3, 2018
cjihrig
approved these changes
Sep 3, 2018
jasnell
approved these changes
Sep 4, 2018
BridgeAR
added
the
author ready
BridgeAR
approved these changes
Sep 5, 2018
targos
added a commit
to targos/node
that referenced
this pull request
Sep 5, 2018
Remove all calls to deprecated V8 functions (here: Value::Equals) inside the code. PR-URL: nodejs#22665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 0740394 |
targos
added a commit
that referenced
this pull request
Sep 5, 2018
Remove all calls to deprecated V8 functions (here: Value::Equals) inside the code. PR-URL: #22665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
added a commit
that referenced
this pull request
Sep 6, 2018
Remove all calls to deprecated V8 functions (here: Value::Equals) inside the code. PR-URL: #22665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 6, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all calls to deprecated V8 functions (here: String::Equals)
inside the code.
@addaleax @ryzokuken @jasnell
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes