Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

config: support default user on IBM i #22669

Closed
wants to merge 1 commit into from
Closed

config: support default user on IBM i #22669

wants to merge 1 commit into from

Conversation

dmabupt
Copy link
Contributor

@dmabupt dmabupt commented Sep 3, 2018

setuid() can not accept a 'nobody' parameter on IBM i.
The default user (QSECOFR) on IBM i has user id 0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

setuid() can not accept a 'nobody' parameter on IBM i.
The default user (QSECOFR) on IBM i has user id 0.
@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Sep 3, 2018
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to npm should be made upstream to https://github.com/npm/cli, not here.

@dmabupt dmabupt closed this Sep 3, 2018
@dmabupt
Copy link
Contributor Author

dmabupt commented Oct 8, 2018

Close this pull request and move it to npm/cli#65
@gireeshpunathil @addaleax
Would you please review npm/cli#65 ?

@gireeshpunathil
Copy link
Member

@dmabupt - I am not a collaborator on that repo, so cannot do formal review

@sam-github
Copy link
Contributor

@gireeshpunathil Do you know who at IBM would be able to test that change and confirm to npm that it is correct?

@gireeshpunathil
Copy link
Member

I guess @dmabupt himself, if not the i focal is @ThePrez

@ThePrez
Copy link
Contributor

ThePrez commented Oct 10, 2018

@sam-github, that would be me, @mgoffmn, or @dmabupt (the submitter is from the IBM development team, sorry for any confusion). We have reviewed and tested.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants