Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: some refactoring of node_zlib.cc #23019

Closed
wants to merge 3 commits into from
Closed

src: some refactoring of node_zlib.cc #23019

wants to merge 3 commits into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/974/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. zlib Issues and PRs related to the zlib subsystem. labels Sep 22, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17391/

danbev pushed a commit that referenced this pull request Sep 25, 2018
@addaleax @danbev
src: refactor zlib dictionary to STL vector
c496e58 
PR-URL: #23019
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
danbev pushed a commit that referenced this pull request Sep 25, 2018
@addaleax @danbev
src: make ZCtx::Init() non-static
0630da1 
PR-URL: #23019
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
danbev pushed a commit that referenced this pull request Sep 25, 2018
@addaleax @danbev
src: define zlib constants in node_zlib.cc
ead5c4c 
This is in order to avoid having two separate definitions
for `node_zlib_mode`.

PR-URL: #23019
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@danbev
Copy link
Contributor

danbev commented Sep 25, 2018

Landed in ead5c4c, 0630da1, and c496e58.

@danbev danbev closed this Sep 25, 2018
targos pushed a commit that referenced this pull request Sep 25, 2018
@addaleax @targos
src: refactor zlib dictionary to STL vector
56b1a3c 
PR-URL: #23019
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 25, 2018
@addaleax @targos
src: make ZCtx::Init() non-static
d72867e 
PR-URL: #23019
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 25, 2018
@addaleax @targos
src: define zlib constants in node_zlib.cc
90f1200 
This is in order to avoid having two separate definitions
for `node_zlib_mode`.

PR-URL: #23019
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @danbev @jasnell @devsnek