-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
doc: remove GA tracking #23083
doc: remove GA tracking #23083
Conversation
The Google Analytics tracking wasn't wholly uncontroversial and hasn't been used in practice. Remove it. Refs: nodejs#6601 Fixes: nodejs#22652
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
are we sure it is unused? /cc @nodejs/community-committee |
Only use I've seen of the data is to help guide some focus in the website rede#itiative, but it didn't do much other than confirm already existing assumptions. I'm personally always in favor of collecting more data on the off chance we need it / will find it useful in the future – but I also respect and understand the privacy concerns expressed by other people here, so I don't want to block this from happening unless others feel strongly to the contrary. @bnb, any historical knowledge on how GA tracking has been used? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Access logs are a better source for such data because I guess among the developer community, a reasonable amount of users would use a tracking blocker and these users would not be picked up by GA, but would still be visible in the access logs.
I'm not familiar with the process to getting a hold of those. Are access logs a resource that to which we have reasonable access? If we have (better) alternatives to the data collected by GA, then it would seem unnecessary. |
I'm not that deeply involved in the organization, but I guess one could set up a log parser which can present similar stats than GA, without privacy concerns. |
I think ATM this falls under the BuildWG's responsibility. The current setup of the WWW server is mirrored in the scripts at https://github.com/nodejs/build/tree/master/setup/www (server is NGINX). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Re-run of failing node-test-commit-arm ✔️ |
Landed in df6a130. |
The Google Analytics tracking wasn't wholly uncontroversial and hasn't been used in practice. Remove it. PR-URL: #23083 Fixes: #22652 Refs: #6601 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
The Google Analytics tracking wasn't wholly uncontroversial and hasn't been used in practice. Remove it. PR-URL: #23083 Fixes: #22652 Refs: #6601 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
The Google Analytics tracking wasn't wholly uncontroversial and hasn't been used in practice. Remove it. PR-URL: #23083 Fixes: #22652 Refs: #6601 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
We removed GA in 2018 but it seems like we missed removing it from the partials and it is still being loaded. Refs: nodejs/node#23083 Refs: #2302
It was still present in one file, previous commit just removed the prefetch. Also remove dnt_helper, it was used only by analytics. Refs: #2305 Refs: nodejs/node#23083 Refs: nodejs/node#22652 Refs: #2302
The Google Analytics tracking wasn't wholly uncontroversial and hasn't
been used in practice. Remove it.
Refs: #6601
Fixes: #22652