test: improve test-gc-http-client-connaborted #23091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
changed the title
Trott
changed the title
test-gc-http-client-connaborted is resource-intensive. It times out a lot on CI. Move to sequential.
Trott
force-pushed
the
test-gc-http-client-connaborted
branch
from
2157914 to
0a77d8f
Compare
|
Just to be sure, is this test flaky? It invokes |
|
I thought this one timed out for me with -j 32 --repeat 192, but let me double-check in case I ran a one of the other tests by accident. FWIW, test-gc-tls-external-memory is not flaky for me. |
|
Confirmed this one is flaky too. I can set up some stress tests if we want it documented/confirmed. |
devsnek
approved these changes
Sep 25, 2018
trivikr
approved these changes
Sep 26, 2018
Trott
added
the
author ready
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/17469/ ✔️ |
thefourtheye
approved these changes
Sep 27, 2018
|
Landed in 7603b4a |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 27, 2018
test-gc-http-client-connaborted is resource-intensive. It times out a lot on CI. Move to sequential. PR-URL: nodejs#23091 Fixes: https://github.com/metadata Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 28, 2018
test-gc-http-client-connaborted is resource-intensive. It times out a lot on CI. Move to sequential. PR-URL: #23091 Fixes: https://github.com/metadata Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
test-gc-http-client-connaborted is resource-intensive. It times out a lot on CI. Move to sequential. PR-URL: #23091 Fixes: https://github.com/metadata Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-gc-http-client-connaborted is resource-intensive. It times out a lot on
CI. Move to sequential.
Labeling fast-track to fix flaky CI and because this is awfully easy to undo if someone comes up with a better solution. Please 👍 to approve fast-tracking.
(No
Fixes:metadata on this one!)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes