-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test: replace localhost with os.hostname in fs-readfilesync #23101
Conversation
Can you confirm that the test still works with this change if the host is disconnected from the network? |
(Actually, if you could confirm that it works in its current form on the master branch when disconnected from the network, that would be helpful too!) |
@Trott, sorry for the delay. I have run this test with/without network successfully both on master and on this branch. Edit: I ran them on Windows 10 (10.0.17134 Build 17134), just to clarify. |
This is a Windows-only test, I believe, so... @nodejs/platform-windows Can one or two folks review? @nodejs/testing too... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat issue and workaround.
Landed in 1be804d. |
Fixes: #21501
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes (waiting for CI)@targos could you please try this on the setup mentioned in the issue if possible?