Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

build: add pgo specific variables to common.gypi #23102

Closed
wants to merge 1 commit into from
Closed

build: add pgo specific variables to common.gypi #23102

wants to merge 1 commit into from

Conversation

lundibundi
Copy link
Member

To make sure this doesn't get lost.
@refack PTAL.

Refs: #22772 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@lundibundi lundibundi requested a review from refack September 26, 2018 11:32
@nodejs-github-bot
Copy link
Collaborator

@lundibundi build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1025/pipeline

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Sep 26, 2018
@lundibundi lundibundi added the needs-ci PRs that need a full CI run. label Sep 26, 2018
@refack
Copy link
Contributor

refack commented Sep 26, 2018

@refack PTAL.

Ohh, thank you for picking this up!

@refack
Copy link
Contributor

refack commented Sep 26, 2018

/CC @nodejs/build-files @nodejs/gyp

@lundibundi
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17508/

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Sep 30, 2018
@addaleax
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17525/

@lundibundi
Copy link
Member Author

Resume: https://ci.nodejs.org/job/node-test-pull-request/17541/

@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
@addaleax
Copy link
Member

addaleax commented Oct 4, 2018

Landed in 6f7fd7f, thanks for doing the PR!

@addaleax addaleax closed this Oct 4, 2018
addaleax pushed a commit that referenced this pull request Oct 4, 2018
@lundibundi @addaleax
build: add pgo specific variables to common.gypi
6f7fd7f 
Refs: #22772 (comment)

PR-URL: #23102
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 5, 2018
@lundibundi @targos
build: add pgo specific variables to common.gypi
3f46104 
Refs: #22772 (comment)

PR-URL: #23102
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 7, 2018
@lundibundi @targos
build: add pgo specific variables to common.gypi
0f236c8 
Refs: #22772 (comment)

PR-URL: #23102
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@lundibundi @jasnell
build: add pgo specific variables to common.gypi
a90637a 
Refs: #22772 (comment)

PR-URL: #23102
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

@mihalskiy mihalskiy mihalskiy approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lundibundi @nodejs-github-bot @refack @addaleax @jasnell @richardlau @mihalskiy