crypto: replace gotos

[tniessen]

These occurrences of goto are almost trivial and only end up calling End(). I personally don't think it makes the code less expressive, but I'd like to know if someone feels different.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1045/pipeline

[tniessen]

CI: https://ci.nodejs.org/job/node-test-pull-request/17475/
Resumed in https://ci.nodejs.org/job/node-test-pull-request/17478/

[bnoordhuis]

If someone is feeling adventurous: I'd be curious to know if the custom handshake parser still wins out from openssl.

[tniessen]

This conflicts with #23014. I kind of like this variant better, but I can close it if others don't feel the same. I'd prefer to use OnScopeLeave only when necessary to cleanup resources, which isn't the case here in my opinion.

[gireeshpunathil]

@tniessen - I was excited by the power of combining scoped variables. destructors and lambda, to tidy up the code and probably bring-in some functional programming elements to it when I developed #23014 . To me, other than the fact that the trapped object being destructed when leaving the scope (and leverage that destructor to run custom task on return), I don't see any connection with resource clean-up here.

If you think this is more readable and efficient, I am not objecting. thanks!

[tniessen]

Rebased, old HEAD was 158c3eb063ba9983dfaca0067bf87455000f695e. @gireeshpunathil Thanks. I still liked your PR, I even approved it, I just forgot about it when I opened this one.

[addaleax]

CI: https://ci.nodejs.org/job/node-test-pull-request/17532/

[addaleax]

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17558/

[tniessen]

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17559/

[tniessen]

Landed in 640172d, thanks for reviewing.