doc: add table of contents in BUILDING.md #23147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
targos
approved these changes
Sep 28, 2018
vsemozhetbyt
approved these changes
Sep 28, 2018
BUILDING.md
Outdated
| * [Supported platforms](#supported-platforms) | ||
| * [Input](#input) | ||
| * [Strategy](#strategy) | ||
| * [Supported platforms](#supported-platforms) |
There was a problem hiding this comment.
#supported-platforms-1
lpinca
approved these changes
Sep 28, 2018
DiegoRBaquero
approved these changes
Sep 28, 2018
jasnell
approved these changes
Sep 28, 2018
vsemozhetbyt
added
the
author ready
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
trivikr
approved these changes
Sep 29, 2018
vsemozhetbyt
added
the
fast-track
|
Landed in a21af5b |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Sep 29, 2018
PR-URL: #23147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 1, 2018
PR-URL: #23147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
PR-URL: #23147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Oct 10, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add table of contents in BUILDING.md.
Checklist