Skip to content

crypto: make PEM parsing RFC7468-compliant #23164

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

crypto: make PEM parsing RFC7468-compliant #23164

wants to merge 2 commits into from

Conversation

tniessen
Copy link
Member

This change uses PEM_bytes_read_bio as suggested by @bnoordhuis to parse public keys as described in RFC7468.

Fixes: #13612
Fixes: #22815

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1063/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Sep 29, 2018
bnoordhuis
bnoordhuis approved these changes Oct 1, 2018
View reviewed changes
src/node_crypto.cc Outdated
static ParsePublicKeyResult TryParsePublicKey(
EVPKeyPointer* pkey,
const BIOPointer& bp,
char* name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be const char* name, right?

@tniessen
Copy link
Member Author

tniessen commented Oct 1, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/17561/
Resumed in https://ci.nodejs.org/job/node-test-pull-request/17568/
Resumed in https://ci.nodejs.org/job/node-test-pull-request/17582/

cc @nodejs/crypto

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2018
@tniessen
Copy link
Member Author

tniessen commented Oct 2, 2018

Landed in ad07e44, thanks for reviewing.

@tniessen tniessen closed this Oct 2, 2018
tniessen added a commit that referenced this pull request Oct 2, 2018
@tniessen
crypto: make PEM parsing RFC7468-compliant
ad07e44 
PR-URL: #23164
Fixes: #13612
Fixes: #22815
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
targos pushed a commit that referenced this pull request Oct 3, 2018
@tniessen @targos
crypto: make PEM parsing RFC7468-compliant
1a21cf1 
PR-URL: #23164
Fixes: #13612
Fixes: #22815
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
4 participants
@tniessen @nodejs-github-bot @bnoordhuis @jasnell