doc: update AUTHORS file, add tool for doing it #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
update-authors
branch
2 times, most recently
from
acc3c91 to
45dc9b8
Compare
| @@ -151,6 +149,7 @@ Theo Schlossnagle <jesus@omniti.com> | |||
| Kai Chen <kaichenxyz@gmail.com> | |||
| Daniel Chcouri <333222@gmail.com> | |||
| Mihai Călin Bazon <mihai@bazon.net> | |||
| Kevin Millikin <kmillikin@chromium.org> | |||
There was a problem hiding this comment.
@chromium.org addresses should be filtered out. Those come from cherry-picked V8 patches; their authors didn't contribute to node.js, they contributed to V8.
|
I like where this is going but it still needs some .mailmap tweak to flush out duplicates / people contributing from different email addresses. |
|
See 7c29bf7 for .mailmap updates and script tweaks to remove @chromium.org and Erik, will squash when we're happy with this. |
|
LGTM, one tiny nit. |
rvagg
added a commit
that referenced
this pull request
Jan 7, 2015
PR-URL: #232 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
landed in 53ba494 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 29, 2021
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: nodejs#232 Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 29, 2021
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: nodejs#232 (diff) Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 31, 2021
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: #232 (diff) Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions. PR-URL: #40648 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: #232 (diff) Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions. PR-URL: #40648 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: #232 (diff) Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions. PR-URL: #40648 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Dec 1, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the list to give a bit of love to those who have contributed.
Generated automatically from the git log, see attached tool, still needs to be done regularly