doc: Reorder collaborators by their usernames

[jbergstroem]

Followup from #1966 where we didn't quite agree on TC ordering. Now that we've resolved that, I'm suggesting we sort by github usernames.

(hopefully I got my a-b-c's straight)

Fixes #1972.

[bnoordhuis]

Rubber-stamp LGTM.

I didn't notice it before but the convention is to use all lowercase in the first line of the commit log, i.e. s/Reorder/reorder/.

[targos]

Would it make sense to order by GH username but keep the real name at the beginning ?
The rendering is weird: https://github.com/jbergstroem/io.js/blob/doc/author-order-r2/README.md#tsc-technical-steering-committee

[jbergstroem]

@bnoordhuis I like that. Been pondering this myself as well. Thanks.

@targos what do you mean by 'weird'? With my suggested change, I like how its an easy copy paste into a Reviewed-By as well as finding people by their usernames (read: navigating github).

[targos]

@jbergstroem You can do the same in both versions.

Current readme:

• Michaël Zasso <mic.besace@gmail.com> (@targos)

Your version:

• @targos: Michaël Zasso <mic.besace@gmail.com>

I personally prefer current.

[targos]

I realize that if the username stays at the end, it's not easy to find it visually.
The weird part is that each line starts with @. You could perhaps just remove this character ?

[jbergstroem]

I'm happy to remove it [the prefixed @] if others agree.

[thefourtheye]

I am okay with removing @. Also can we mention that the names are in alphabetical order?

[jbergstroem]

@thefourtheye I thought about that, but it felt silly - similar to us adding a note about the current order is based on when they joined?

[thefourtheye]

Okay no problem :)

[jbergstroem]

@thefourtheye better?

Perhaps someone else of the @nodejs/collaborators wants to chip in?

Also: moving into flavour here, but I'd be happy to drop wrapping names in bold.

[thefourtheye]

@jbergstroem LGTM

[trevnorris]

The Reviewed-By argument is not very applicable now that we've also decided to move forward with automated patch landing. Other than that, what's the reason for ordering based on github handle?

[jbergstroem]

@trevnorris good point -- the only other reason I could think of would be avoiding sorting by a-z when we for instance have cyrillic in there.

[trevnorris]

@jbergstroem Sure thing. Even if there wasn't an argument for alphabetically ordering the names the change doesn't bother me. Just wanted to make sure everyone realized that point. :)

Or... We could use a randomization algorithm and have it list everyone...

[orangemocha]

+1

[jbergstroem]

ok, last stab; now follows the newly implemented 'reviewed-by' style:
$username - $name $surname <email@address.com>

[orangemocha]

LGTM

[orangemocha]

This can be landed in Jenkins as NODES_SUBSET pure_docs_change, skipping tests.

[thefourtheye]

LGTM

[jbergstroem]

Merged in 6ce8f5f. Thanks for feedback and review.