test: add test for _setSimultaneousAccepts() #24180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
approved these changes
Nov 6, 2018
addaleax
added
net
addaleax
approved these changes
Nov 6, 2018
BridgeAR
added
the
code-and-learn
|
@amel-true Could you undo the merge commit here? Our CI doesn’t play well with them, and we don’t allow merge commits in the |
jasnell
approved these changes
Nov 10, 2018
|
@addaleax yep, i removed merge commit |
Add a test case that verifies that calling the `_setSimultaneousAccepts()` function twice does not trigger the deprecation warning twice.
|
[commit message was longer than 72 chars, fixed it while landing ] landed as 3235d31 thank you @amel-true for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 13, 2018
Add a test case that verifies that calling _setSimultaneousAccepts() function twice does not trigger the deprecation warning twice. PR-URL: #24180 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Add a test case that verifies that calling _setSimultaneousAccepts() function twice does not trigger the deprecation warning twice. PR-URL: nodejs#24180 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Apr 23, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test case that verifies that calling the
_setSimultaneousAccepts()function twice does not trigger the deprecation warning twice.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes