build: fix benchmark tests on CI #24307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
refack
approved these changes
Nov 11, 2018
|
We should fast-tack this since ATM our daily CI job is broken... |
3 tasks
cjihrig
approved these changes
Nov 11, 2018
Trott
added
the
author ready
|
Resume: https://ci.nodejs.org/job/node-test-commit/23132/ (smartOS green) |
richardlau
approved these changes
Nov 12, 2018
|
Landed in f697457. |
danbev
pushed a commit
that referenced
this pull request
Nov 12, 2018
PR-URL: #24307 Refs: nodejs/build#1568 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24307 Refs: nodejs/build#1568 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24307 Refs: nodejs/build#1568 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
PR-URL: #24307 Refs: nodejs/build#1568 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/build#1568 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes