doc: adjusting formatting when printing #24325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf
|
/cc @refack |
|
Hello @tlhunter and thank you for the contribution! |
|
Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1586/ I'll setup a demo site so we can compare the generated docs. |
|
@nodejs/website |
|
Since these are all under LGTM |
Trott
approved these changes
Nov 17, 2018
bengl
approved these changes
Nov 17, 2018
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 17, 2018
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: nodejs#24325 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
|
Landed in 344a46a |
|
Post land visual test: Screenshot of print preview: Pre:
Post:
|
|
Maybe we can follow up with an improvement to the visual of |
|
I see this in print preview on chrome using @refack links. Pre:
Post:
|
@WaleedAshraf Do you have "Background Graphics" checked? |
|
@refack Got it. |
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: #24325 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: #24325 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: #24325 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: #24325 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
This was referenced Jan 29, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a weekend project I built a PDF generator for the Node.js docs. This project required making small changes to the documentation CSS for aesthetics. Take a look at these PDF files to view the CSS changes in action.
Here's an overview of these changes:
> historyitems since they're collapsed and unreadableChecklist