Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

lib: refactor setupInspector in bootstrap/node.js #24446

Closed
wants to merge 1 commit into from
Closed

lib: refactor setupInspector in bootstrap/node.js #24446

wants to merge 1 commit into from

Conversation

leeight
Copy link
Contributor

@leeight leeight commented Nov 17, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@leeight leeight force-pushed the clean-bootstrap-node branch from af97483 to fa8b825 Compare November 18, 2018 05:26
@oyyd
Copy link
Contributor

oyyd commented Nov 18, 2018

Hi @leeight. Thanks for your contribution! Can you add a short description about the change in the commit message? As Change-Id: Ic715201ba5eae43f7d535ff93045cb3a965d2752 seems a bit confuzing to me. You can find the guide here (which you may have known about before)

@leeight
lib: refactor setupInspector in bootstrap/node.js
a4984e6 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.
@leeight leeight force-pushed the clean-bootstrap-node branch from fa8b825 to a4984e6 Compare November 18, 2018 05:49
@leeight
Copy link
Contributor Author

leeight commented Nov 18, 2018

@oyyd Thanks for your feedback. I updated the commit message and removed the Change-Id.

@oyyd
Copy link
Contributor

oyyd commented Nov 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18719/

oyyd
oyyd approved these changes Nov 18, 2018
View reviewed changes
Copy link
Contributor

@oyyd oyyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oyyd oyyd added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 18, 2018
@danbev
Copy link
Contributor

danbev commented Nov 20, 2018

Landed in 771585f.

@danbev danbev closed this Nov 20, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 20, 2018
@leeight @danbev
lib: refactor setupInspector in bootstrap/node.js
771585f 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: nodejs#24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos pushed a commit that referenced this pull request Nov 20, 2018
@leeight @targos
lib: refactor setupInspector in bootstrap/node.js
c331939 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@leeight @rvagg
lib: refactor setupInspector in bootstrap/node.js
e14abfe 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@leeight @codebytere
lib: refactor setupInspector in bootstrap/node.js
522a6ed 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@leeight @refack
lib: refactor setupInspector in bootstrap/node.js
00bd032 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: nodejs#24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@leeight @codebytere
lib: refactor setupInspector in bootstrap/node.js
6bd055f 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@oyyd oyyd oyyd approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leeight @oyyd @danbev @jasnell