Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: elevate v8 namespaces for node_url.cc #24573

Closed
wants to merge 1 commit into from
Closed

src: elevate v8 namespaces for node_url.cc #24573

wants to merge 1 commit into from

Conversation

Jayasankar-m
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 23, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 23, 2018
@Jayasankar-m
src: elevate v8 namespaces for node_url.cc
9948dc2 
elevate namespace for repeated entities.
@addaleax
Copy link
Member

addaleax commented Nov 23, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/18896/ ✔️

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2018
@Trott
Copy link
Member

Trott commented Nov 25, 2018

Landed in c5db2df

@Trott Trott closed this Nov 25, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 25, 2018
@Jayasankar-m @Trott
src: elevate v8 namespaces for node_url.cc
c5db2df 
Elevate namespace for repeated entities.

PR-URL: nodejs#24573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 25, 2018
@Jayasankar-m @targos
src: elevate v8 namespaces for node_url.cc
bdf66e4 
Elevate namespace for repeated entities.

PR-URL: #24573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Jayasankar-m @rvagg
src: elevate v8 namespaces for node_url.cc
8a91fc1 
Elevate namespace for repeated entities.

PR-URL: #24573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Jayasankar-m @refack
src: elevate v8 namespaces for node_url.cc
fe07dff 
Elevate namespace for repeated entities.

PR-URL: nodejs#24573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@Jayasankar-m @BethGriggs
src: elevate v8 namespaces for node_url.cc
8c48302 
Elevate namespace for repeated entities.

PR-URL: #24573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Jayasankar-m @rvagg
src: elevate v8 namespaces for node_url.cc
ef12744 
Elevate namespace for repeated entities.

PR-URL: #24573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Jayasankar-m @addaleax @Trott @lpinca @cjihrig @joyeecheung @trivikr @gireeshpunathil @BethGriggs @nodejs-github-bot