Skip to content

src: remove unused variables node_util.cc #24717

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: remove unused variables node_util.cc #24717

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Nov 29, 2018

Currently the following warnings are generated:

../src/node_util.cc:59:16: warning: unused variable 'env' [-Wunused-variable]
  Environment* env = Environment::GetCurrent(args);
               ^
../src/node_util.cc:78:16: warning: unused variable 'env' [-Wunused-variable]
  Environment* env = Environment::GetCurrent(args);
               ^
2 warnings generated.

This commit removes these unused variables.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: remove unused variables node_util.cc
f504d19 
Currently the following warnings are generated:
../src/node_util.cc:59:16: warning: unused variable 'env' [-Wunused-variable]
  Environment* env = Environment::GetCurrent(args);
               ^
../src/node_util.cc:78:16: warning: unused variable 'env' [-Wunused-variable]
  Environment* env = Environment::GetCurrent(args);
               ^
2 warnings generated.

This commit removes these unused variables.
@nodejs-github-bot
Copy link
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1720/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. labels Nov 29, 2018
@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI https://ci.nodejs.org/job/node-test-pull-request/19048/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2018
@Trott
Copy link
Member

Trott commented Nov 29, 2018

Collaborators, 👍 to fast-track.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 29, 2018
@lpinca
Copy link
Member

lpinca commented Nov 29, 2018

I think there is a typo in commit title (missing "in").

@Trott
Copy link
Member

Trott commented Nov 30, 2018

Landed in 171b810

@Trott Trott closed this Nov 30, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 30, 2018
@danbev @Trott
src: remove unused variables in node_util.cc
171b810 
Currently two warnings are generated regarding unused variables.
This commit removes the unused variables.

PR-URL: nodejs#24717
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danbev danbev deleted the node_util_warning branch December 4, 2018 04:24
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@danbev @BridgeAR
src: remove unused variables in node_util.cc
87c864c 
Currently two warnings are generated regarding unused variables.
This commit removes the unused variables.

PR-URL: #24717
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@danbev @refack
src: remove unused variables in node_util.cc
57c5b47 
Currently two warnings are generated regarding unused variables.
This commit removes the unused variables.

PR-URL: nodejs#24717
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@maclover7 maclover7 maclover7 approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danbev @nodejs-github-bot @Trott @lpinca @cjihrig @maclover7 @joyeecheung @richardlau @BethGriggs