-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
deps: upgrade npm to 6.5.0 #24734
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
deps: upgrade npm to 6.5.0 #24734
Conversation
Oh right, node@11 is out now too. Should we add it to the list? |
@zkat Do you mean the "Where this should land" list? |
This needs some reviews, although I imagine they'll be largely of the rubber-stamp variety... @nodejs/npm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM
Only failure is a known flake … Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19187/ |
Blocking until npm |
Resume Build CI again: https://ci.nodejs.org/job/node-test-pull-request/19197/ ✔️ |
6.5.0 has been promoted to latest... as such we can land this on December 25th... A holiday present! |
Other CI results are stale: https://ci.nodejs.org/job/node-test-pull-request/19793/ edit: Two flakes on AIX, re-running: https://ci.nodejs.org/job/node-test-commit-aix/20022/ |
fbc3d70
to
6edfb2d
Compare
rebased against master, one more CI https://ci.nodejs.org/job/node-test-pull-request/19798/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
landed in 13ae538 |
PR-URL: #24734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: nodejs#24734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * crypto: - always accept certificates as public keys (Tobias Nießen) #24234 - add key object API (Tobias Nießen) [#24234](#24234) - update root certificates (Sam Roberts) #25113 * deps: - upgrade to libuv 1.24.1 (cjihrig) #25078 - upgrade npm to 6.5.0 (Audrey Eschright) #24734 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25175
PR-URL: #24734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * crypto: - always accept certificates as public keys (Tobias Nießen) #24234 - add key object API (Tobias Nießen) [#24234](#24234) - update root certificates (Sam Roberts) #25113 * deps: - upgrade to libuv 1.24.1 (cjihrig) #25078 - upgrade npm to 6.5.0 (Audrey Eschright) #24734 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25175
Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * crypto: - always accept certificates as public keys (Tobias Nießen) #24234 - add key object API (Tobias Nießen) [#24234](#24234) - update root certificates (Sam Roberts) #25113 * deps: - upgrade to libuv 1.24.1 (cjihrig) #25078 - upgrade npm to 6.5.0 (Audrey Eschright) #24734 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25175
Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * crypto: - always accept certificates as public keys (Tobias Nießen) #24234 - add key object API (Tobias Nießen) [#24234](#24234) - update root certificates (Sam Roberts) #25113 * deps: - upgrade to libuv 1.24.1 (cjihrig) #25078 - upgrade npm to 6.5.0 (Audrey Eschright) #24734 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25175
PR-URL: nodejs#24734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Notable Changes: * cli: - add --max-http-header-size flag (cjihrig) nodejs#24811 * crypto: - always accept certificates as public keys (Tobias Nießen) nodejs#24234 - add key object API (Tobias Nießen) [nodejs#24234](nodejs#24234) - update root certificates (Sam Roberts) nodejs#25113 * deps: - upgrade to libuv 1.24.1 (cjihrig) nodejs#25078 - upgrade npm to 6.5.0 (Audrey Eschright) nodejs#24734 * http: - add maxHeaderSize property (cjihrig) nodejs#24860 PR-URL: nodejs#25175
PR-URL: #24734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #24734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #24734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #24734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesWhere this should land
Notable Changes
This is a pre-release of
npm@6.5.0
including a number of bugfixes and documentation updates.fc1a8d185
Backronymnpm ci
tonpm clean-install
. (@zkat)89652cb9b
npm.community#1661 Fix sign-git-commit options. They were previously totally wrong. (@zkat)d3e8a7c72
npm.community#2303 Make summary output fornpm ci
go tostdout
, notstderr
. (@alopezsanchez)Another reminder that we've moved our issue tracking! You can read more about our move away from GitHub for issue tracking on our blog.
Changelogs