test: check invalid argument error for option #24736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a test for the validateArguments function in TextDecoder
Trott
approved these changes
Nov 30, 2018
cjihrig
approved these changes
Nov 30, 2018
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19127/ ✔️ |
|
Landed in f8f9601. |
danbev
pushed a commit
that referenced
this pull request
Dec 3, 2018
This commit adds a test for the validateArguments function in TextDecoder. PR-URL: #24736 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
This commit adds a test for the validateArguments function in TextDecoder. PR-URL: #24736 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This commit adds a test for the validateArguments function in TextDecoder. PR-URL: nodejs#24736 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
This commit adds a test for the validateArguments function in TextDecoder. PR-URL: #24736 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
This commit adds a test for the validateArguments function in TextDecoder. PR-URL: #24736 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a test for the validateArguments function in TextDecoder
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAs another note I would like to test the function
makeTextDecoderJSin encoding.js but I do not know how to force hasIntl to be false without rebuilding node with the option--without-intl. Is there a way to do this at runtime? (Maybe it could be providing a icu-data-dir that has it disabled? I just don't know what that file would look like if that is the case)If anyone knows a way to set hasIntl to off let me know because I can just include those tests and get the coverage of encoding.js up even more!