Skip to content

module: use validateString in modules/cjs #24863

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

module: use validateString in modules/cjs #24863

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 6, 2018

Simply use validateString in modules/cjs.

Refs: #22101

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@ZYSzys ZYSzys mentioned this pull request Dec 6, 2018
Closed
2 tasks
@trivikr
Copy link
Member

trivikr commented Dec 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19318/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 8, 2018
@Trott
Copy link
Member

Trott commented Dec 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19335/

@Trott
Copy link
Member

Trott commented Dec 9, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19342/

@Trott
Copy link
Member

Trott commented Dec 9, 2018

Landed in 4dc10ac

@Trott Trott closed this Dec 9, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 9, 2018
@ZYSzys @Trott
module: use validateString in modules/cjs
4dc10ac 
PR-URL: nodejs#24863
Refs: nodejs#22101
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@ZYSzys ZYSzys deleted the validator-string branch December 11, 2018 09:00
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
@ZYSzys @BethGriggs
module: use validateString in modules/cjs
2a11e6a 
PR-URL: #24863
Refs: #22101
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@ZYSzys @refack
module: use validateString in modules/cjs
70adfe1 
PR-URL: nodejs#24863
Refs: nodejs#22101
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@ZYSzys @BethGriggs
module: use validateString in modules/cjs
229f901 
PR-URL: #24863
Refs: #22101
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@ZYSzys @BethGriggs
module: use validateString in modules/cjs
153f501 
PR-URL: #24863
Refs: #22101
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@ZYSzys @rvagg
module: use validateString in modules/cjs
6cede0c 
PR-URL: #24863
Refs: #22101
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ZYSzys @trivikr @Trott @lpinca @cjihrig @richardlau @BridgeAR @BethGriggs