util: remove todo #24982
Closed
util: remove todo #24982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most people are going to use the existing option and switching the name now comes with a cost which does not seem to justify the improvement.
nodejs-github-bot
added
the
util
targos
approved these changes
Dec 12, 2018
lpinca
approved these changes
Dec 12, 2018
BridgeAR
added
the
author ready
antsmartian
approved these changes
Dec 12, 2018
Trott
approved these changes
Dec 15, 2018
|
Landed in 885de1b |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2018
Most people are going to use the existing option and switching the name now comes with a cost which does not seem to justify the improvement. PR-URL: nodejs#24982 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
Most people are going to use the existing option and switching the name now comes with a cost which does not seem to justify the improvement. PR-URL: #24982 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
sagitsofan
pushed a commit
to sagitsofan/node
that referenced
this pull request
Dec 24, 2018
Most people are going to use the existing option and switching the name now comes with a cost which does not seem to justify the improvement. PR-URL: nodejs#24982 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Most people are going to use the existing option and switching the name now comes with a cost which does not seem to justify the improvement. PR-URL: nodejs#24982 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Mar 14, 2019
Most people are going to use the existing option and switching the name now comes with a cost which does not seem to justify the improvement. PR-URL: #24982 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 29, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most people are going to use the existing option and switching the
name now comes with a cost which does not seem to justify the
improvement.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes