Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

querystring: remove eslint-disable #24995

Merged
merged 2 commits into from
Dec 14, 2018
Merged

querystring: remove eslint-disable #24995

merged 2 commits into from
Dec 14, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 12, 2018

Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1913/pipeline

@nodejs-github-bot nodejs-github-bot added the querystring Issues and PRs related to the built-in querystring module. label Dec 12, 2018
@Trott
Copy link
Member

Trott commented Dec 12, 2018

Is this worth benchmarking?

@targos
Copy link
Member

targos commented Dec 12, 2018

I'd say no. Performance can only be improved by this change

@antsmartian antsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2018
@Trott
Copy link
Member

Trott commented Dec 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19532/

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 14, 2018

Yellow CI: https://ci.nodejs.org/job/node-test-pull-request/19530/

@cjihrig
querystring: remove eslint-disable
034ec64 
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: nodejs#24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@cjihrig
url: remove an eslint-disable comment
8ac6c05 
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: nodejs#24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@cjihrig cjihrig merged commit 8ac6c05 into nodejs:master Dec 14, 2018
@cjihrig cjihrig deleted the lint branch December 14, 2018 18:16
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@cjihrig @BethGriggs
url: remove an eslint-disable comment
e7b77ea 
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@cjihrig @BethGriggs
querystring: remove eslint-disable
2e94f3b 
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
querystring: remove eslint-disable
cabdccb 
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: nodejs#24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
url: remove an eslint-disable comment
d897314 
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: nodejs#24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@cjihrig @BethGriggs
url: remove an eslint-disable comment
b3932ef 
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@cjihrig @BethGriggs
url: remove an eslint-disable comment
75ddc04 
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig @rvagg
url: remove an eslint-disable comment
3aff725 
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@cjihrig @BethGriggs
querystring: remove eslint-disable
d3bfdcb 
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@cjihrig @BethGriggs
querystring: remove eslint-disable
8e56a12 
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
querystring: remove eslint-disable
45481bc 
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@Trott Trott Trott approved these changes

@antsmartian antsmartian antsmartian approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @Trott @targos @ChALkeR @antsmartian @BridgeAR @BethGriggs