Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

os: use uv_os_gethostname() in hostname() #25111

Merged
merged 1 commit into from
Dec 20, 2018
Merged

os: use uv_os_gethostname() in hostname() #25111

merged 1 commit into from
Dec 20, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 18, 2018

This commit changes the C++ implementation of os.hostname() to use uv_os_gethostname().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1993/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. labels Dec 18, 2018
@Fishrock123
Copy link
Contributor

What is the expected impact of this?

@danbev
Copy link
Contributor

danbev commented Dec 19, 2018 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19670/ ✔️

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 19, 2018

What is the expected impact of this?

Just code cleanup.

@cjihrig
os: use uv_os_gethostname() in hostname()
3438f4b 
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: nodejs#25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 3438f4b into nodejs:master Dec 20, 2018
@cjihrig cjihrig deleted the hostname branch December 20, 2018 18:55
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@cjihrig @MylesBorins
os: use uv_os_gethostname() in hostname()
1a562cc 
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: #25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@cjihrig @MylesBorins
os: use uv_os_gethostname() in hostname()
add566e 
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: #25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
os: use uv_os_gethostname() in hostname()
3129804 
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: nodejs#25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@cjihrig @BethGriggs
os: use uv_os_gethostname() in hostname()
4d6a8f5 
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: #25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@cjihrig @BethGriggs
os: use uv_os_gethostname() in hostname()
ba51991 
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: #25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@cjihrig @BethGriggs
os: use uv_os_gethostname() in hostname()
cf06b85 
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: #25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
os: use uv_os_gethostname() in hostname()
d468848 
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: #25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@FlyingDR FlyingDR mentioned this pull request Aug 9, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @Fishrock123 @danbev @jasnell @addaleax @richardlau