Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

doc: fix lint in CHANGELOG_V6 #25233

Closed
wants to merge 1 commit into from
Closed

doc: fix lint in CHANGELOG_V6 #25233

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

introduced in 7b9c9b3

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2072/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 26, 2018
@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 26, 2018
@MylesBorins
Copy link
Contributor Author

Can we please fast-track?

@Trott
Copy link
Member

Trott commented Dec 26, 2018

+1 to fast-track

@MylesBorins
Copy link
Contributor Author

landed in 3614157

MylesBorins added a commit that referenced this pull request Dec 26, 2018
@MylesBorins
doc: fix lint in CHANGELOG_V6
3614157 
introduced in 7b9c9b3

PR-URL: #25233
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@MylesBorins @refack
doc: fix lint in CHANGELOG_V6
e03523d 
introduced in 7b9c9b3

PR-URL: nodejs#25233
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Trott Trott Trott approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MylesBorins @nodejs-github-bot @Trott @devsnek