Skip to content

test: remove inherits() usage #25245

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: remove inherits() usage #25245

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 28, 2018 •
edited
Loading

This switches all util.inherits() calls to use Object.setPrototypeOf() instead in the test dir.

Only the test-util-inherits is preserve since util.inherits() isn't removed entirely.

Refs: #24755 #24395

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 28, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19871/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 30, 2018
@addaleax
Copy link
Member

addaleax commented Dec 31, 2018 •
edited by Trott
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19881/ ✅

@Trott
Copy link
Member

Trott commented Dec 31, 2018

Landed in 2f981cd

@Trott Trott closed this Dec 31, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 31, 2018
@ZYSzys @Trott
test: remove util.inherits() usage
2f981cd 
PR-URL: nodejs#25245
Refs: nodejs#24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ZYSzys ZYSzys deleted the test-remove-util-inherits branch December 31, 2018 04:08
targos pushed a commit that referenced this pull request Jan 1, 2019
@ZYSzys @targos
test: remove util.inherits() usage
4ca4b54 
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@ZYSzys @refack
test: remove util.inherits() usage
ada2f32 
PR-URL: nodejs#25245
Refs: nodejs#24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
@ZYSzys ZYSzys mentioned this pull request Jul 21, 2019
Closed
3 tasks
BethGriggs pushed a commit that referenced this pull request Jul 26, 2019
@ZYSzys @BethGriggs
test: remove util.inherits() usage
f332265 
Backport-PR-URL: #28795
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Jul 26, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZYSzys @addaleax @Trott @BridgeAR @BethGriggs @nodejs-github-bot