test: fix test-net-connect-econnrefused #25389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/pummel/test-net-connect-econnrefuse.js was failing because `console.log()` resulted in an extra handle being returned by `process._getActiveHandles()`. Remove the unnecessary `console.log()`.
|
Pummel tests are not (yet) run on CI so lite CI should be sufficient. |
BethGriggs
approved these changes
Jan 8, 2019
cjihrig
approved these changes
Jan 8, 2019
richardlau
approved these changes
Jan 8, 2019
jasnell
approved these changes
Jan 8, 2019
lpinca
approved these changes
Jan 8, 2019
BridgeAR
approved these changes
Jan 10, 2019
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 10, 2019
test/pummel/test-net-connect-econnrefused.js was failing because `console.log()` resulted in an extra handle being returned by `process._getActiveHandles()`. Remove the unnecessary `console.log()`. PR-URL: nodejs#25389 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in b2f74f7. Fixed the typo in the commit message while landing. |
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
test/pummel/test-net-connect-econnrefused.js was failing because `console.log()` resulted in an extra handle being returned by `process._getActiveHandles()`. Remove the unnecessary `console.log()`. PR-URL: #25389 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
test/pummel/test-net-connect-econnrefused.js was failing because `console.log()` resulted in an extra handle being returned by `process._getActiveHandles()`. Remove the unnecessary `console.log()`. PR-URL: nodejs#25389 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
test/pummel/test-net-connect-econnrefused.js was failing because `console.log()` resulted in an extra handle being returned by `process._getActiveHandles()`. Remove the unnecessary `console.log()`. PR-URL: #25389 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
test/pummel/test-net-connect-econnrefused.js was failing because `console.log()` resulted in an extra handle being returned by `process._getActiveHandles()`. Remove the unnecessary `console.log()`. PR-URL: #25389 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
test/pummel/test-net-connect-econnrefused.js was failing because `console.log()` resulted in an extra handle being returned by `process._getActiveHandles()`. Remove the unnecessary `console.log()`. PR-URL: #25389 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced May 29, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/pummel/test-net-connect-econnrefuse.js was failing because
console.log()resulted in an extra handle being returned byprocess._getActiveHandles(). Remove the unnecessaryconsole.log().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes