Skip to content

test: add test for fs.lchmod #25439

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: add test for fs.lchmod #25439

wants to merge 1 commit into from
+67 −0

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Jan 11, 2019 •
edited
Loading

Test passed on macOS:

$ uname                                                                                                                           
Darwin
$ python tools/test.py -J --mode=release parallel/test-fs-lchmod 
[00:00|% 100|+   1|-   0]: Done
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 11, 2019
@lpinca
Copy link
Member

lpinca commented Jan 11, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20066/

@shisama
Copy link
Contributor

shisama commented Jan 14, 2019 •
edited by addaleax
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20104/ (:heavy_check_mark:)

@addaleax
Copy link
Member

addaleax commented Jan 14, 2019 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20117/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2019
@addaleax
Copy link
Member

Landed in 1c7b5db

@addaleax addaleax closed this Jan 14, 2019
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@ZYSzys @addaleax
test: add test for fs.lchmod
1c7b5db 
PR-URL: #25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Jan 14, 2019
@ZYSzys @addaleax
test: add test for fs.lchmod
7bf10e3 
PR-URL: nodejs#25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 15, 2019
@ZYSzys @addaleax
test: add test for fs.lchmod
3afb481 
PR-URL: #25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung joyeecheung mentioned this pull request Jan 16, 2019
Closed
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@ZYSzys @BridgeAR
test: add test for fs.lchmod
a4b3a08 
PR-URL: nodejs#25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ZYSzys ZYSzys deleted the test-fs-lchmod branch January 18, 2019 18:02
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@ZYSzys @BethGriggs
test: add test for fs.lchmod
5b1b071 
PR-URL: #25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@ZYSzys @BethGriggs
test: add test for fs.lchmod
6d1ca0b 
PR-URL: #25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@ZYSzys @MylesBorins
test: add test for fs.lchmod
1b6dfac 
PR-URL: #25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@shisama shisama shisama approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZYSzys @lpinca @shisama @addaleax @jasnell @cjihrig @nodejs-github-bot