src: pass along errors from --security-reverts
#25466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass along errors from `Revert()` when a security revert is unknown (which currently applies to all possible values). Previously, we would unconditionally call `exit()`, which is not nice for embedding use cases, and could crash because we were holding a lock for a mutex in `ProcessGlobalArgs()` that would be destroyed by calling `exit()`. Also, add a regression test that makes sure that the process exits with the right exit code and not a crash.
|
@addaleax sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
the
c++
richardlau
approved these changes
Jan 12, 2019
joyeecheung
approved these changes
Jan 13, 2019
|
Fixed the line ending in the test for Windows. |
addaleax
added
the
author ready
cjihrig
approved these changes
Jan 14, 2019
jasnell
approved these changes
Jan 14, 2019
This was referenced Jan 16, 2019
|
Re-run of failing node-test-commit-arm |
|
ARM Rebuild again: https://ci.nodejs.org/job/node-test-commit-arm/21519/ |
|
Fresh full CI (:crossed_fingers:): https://ci.nodejs.org/job/node-test-pull-request/20246/ |
|
Landed in 38ab1e9 |
addaleax
added a commit
that referenced
this pull request
Jan 22, 2019
Pass along errors from `Revert()` when a security revert is unknown (which currently applies to all possible values). Previously, we would unconditionally call `exit()`, which is not nice for embedding use cases, and could crash because we were holding a lock for a mutex in `ProcessGlobalArgs()` that would be destroyed by calling `exit()`. Also, add a regression test that makes sure that the process exits with the right exit code and not a crash. PR-URL: #25466 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
that referenced
this pull request
Jan 23, 2019
Pass along errors from `Revert()` when a security revert is unknown (which currently applies to all possible values). Previously, we would unconditionally call `exit()`, which is not nice for embedding use cases, and could crash because we were holding a lock for a mutex in `ProcessGlobalArgs()` that would be destroyed by calling `exit()`. Also, add a regression test that makes sure that the process exits with the right exit code and not a crash. PR-URL: #25466 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass along errors from
Revert()when a security revertis unknown (which currently applies to all possible values).
Previously, we would unconditionally call
exit(), which isnot nice for embedding use cases, and could crash because we
were holding a lock for a mutex in
ProcessGlobalArgs()thatwould be destroyed by calling
exit().Also, add a regression test that makes sure that the process
exits with the right exit code and not a crash.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes