Skip to content

doc: Fix issue with worker_threads docs #25712

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

leebyron
Copy link
Contributor

this example function returns a promise directly rather than implicitly via async/await

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

this example function returns a promise directly rather than implicitly via async/await
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 25, 2019
@leebyron leebyron changed the title Fix issue with worker_threads docs doc: Fix issue with worker_threads docs Jan 25, 2019
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2019
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt pushed a commit that referenced this pull request Jan 29, 2019
This example function returns a promise directly
rather than implicitly via async/await.

PR-URL: #25712
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in a0419dd
Thank you!

targos pushed a commit that referenced this pull request Jan 29, 2019
This example function returns a promise directly
rather than implicitly via async/await.

PR-URL: #25712
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Jan 29, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants