Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: simplify SlicedArguments #25745

Closed
wants to merge 1 commit into from
Closed

src: simplify SlicedArguments #25745

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Re-use the existing MaybeStackBuffer logic for SlicedArguments.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: simplify SlicedArguments
0908549 
Re-use the existing `MaybeStackBuffer` logic for `SlicedArguments`.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2409/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 27, 2019
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20411/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2019
@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20446/

@addaleax
Copy link
Member Author

Resume build again: https://ci.nodejs.org/job/node-test-pull-request/20465/

@addaleax
Copy link
Member Author

Landed in de2bdfb

@addaleax addaleax closed this Jan 30, 2019
@addaleax addaleax deleted the sliced-arguments branch January 30, 2019 23:17
addaleax added a commit that referenced this pull request Jan 30, 2019
@addaleax
src: simplify SlicedArguments
de2bdfb 
Re-use the existing `MaybeStackBuffer` logic for `SlicedArguments`.

PR-URL: #25745
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Jan 30, 2019
@addaleax
src: simplify SlicedArguments
be499c3 
Re-use the existing `MaybeStackBuffer` logic for `SlicedArguments`.

PR-URL: #25745
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig