Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: use nullptr in node_buffer.cc #25820

Closed
wants to merge 1 commit into from
Closed

src: use nullptr in node_buffer.cc #25820

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@gengjiawen
src: use nullptr in node_buffer.cc
abd84f8 
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Jan 30, 2019
@addaleax
Copy link
Member

addaleax commented Feb 1, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20531/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2019
@danbev
Copy link
Contributor

danbev commented Feb 4, 2019 •
edited
Loading

Re-build of failing node-test-commit-windows-fanned (✔️)

@danbev
Copy link
Contributor

danbev commented Feb 4, 2019

Landed in 66f08fd.

@danbev danbev closed this Feb 4, 2019
danbev pushed a commit that referenced this pull request Feb 4, 2019
@gengjiawen @danbev
src: use nullptr in node_buffer.cc
66f08fd 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25820
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@gengjiawen @addaleax
src: use nullptr in node_buffer.cc
00f8e86 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25820
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gengjiawen @addaleax @danbev @jasnell @lpinca @cjihrig @richardlau @nodejs-github-bot