Skip to content

benchmark: remove unreachable return #25883

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

benchmark: remove unreachable return #25883

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Feb 2, 2019

Remove the unreachable return since this.abort has process.exit(1).

node/benchmark/_cli.js

Lines 74 to 84 in 0f8e8f7

this.abort(usage);
return;
}
}
}
module.exports = CLI;
CLI.prototype.abort = function(msg) {
console.error(msg);
process.exit(1);
};

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Feb 2, 2019
@ZYSzys ZYSzys changed the title benchmark: remove useless return in _cli.js benchmark: remove unreachable return Feb 2, 2019
@danbev
Copy link
Contributor

danbev commented Feb 7, 2019

@danbev
Copy link
Contributor

danbev commented Feb 7, 2019

Landed in b4e670d.

@danbev danbev closed this Feb 7, 2019
danbev pushed a commit that referenced this pull request Feb 7, 2019
PR-URL: #25883
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Feb 7, 2019
PR-URL: #25883
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@ZYSzys ZYSzys deleted the benchmark-cli branch February 9, 2019 15:23
@targos targos mentioned this pull request Feb 14, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants