Skip to content

src: remove redundant cast in node_file.cc #25977

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: remove redundant cast in node_file.cc #25977

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 7, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Feb 7, 2019
addaleax
addaleax approved these changes Feb 7, 2019
View reviewed changes
@gengjiawen gengjiawen force-pushed the remove_redundant_cast branch from 2c6ada3 to f1bbaa9 Compare February 7, 2019 09:05
@addaleax
Copy link
Member

addaleax commented Feb 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20670/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 8, 2019
@danbev
Copy link
Contributor

danbev commented Feb 11, 2019

Landed in 851cebb.

@danbev danbev closed this Feb 11, 2019
danbev pushed a commit that referenced this pull request Feb 11, 2019
@gengjiawen @danbev
src: remove redundant cast in node_file.cc
851cebb 
PR-URL: #25977
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gengjiawen gengjiawen deleted the remove_redundant_cast branch February 11, 2019 09:08
targos pushed a commit that referenced this pull request Feb 11, 2019
@gengjiawen @targos
src: remove redundant cast in node_file.cc
d7ae105 
PR-URL: #25977
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @addaleax @danbev @cjihrig @nodejs-github-bot