Skip to content

src: remove unused method in class Http2Stream #25979

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: remove unused method in class Http2Stream #25979

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 7, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Feb 7, 2019
@gengjiawen
Copy link
Member Author

@addaleax Can you review this, thanks.

@addaleax
Copy link
Member

addaleax commented Feb 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20685/

@danbev
Copy link
Contributor

danbev commented Feb 11, 2019

Re-run of failing node-test-commit-windows-fanned (✔️)

@danbev
Copy link
Contributor

danbev commented Feb 11, 2019

Landed in e11388b.

@danbev danbev closed this Feb 11, 2019
danbev pushed a commit that referenced this pull request Feb 11, 2019
@gengjiawen @danbev
src: remove unused method in class Http2Stream
e11388b 
PR-URL: #25979
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Feb 11, 2019
@gengjiawen @targos
src: remove unused method in class Http2Stream
7ab34ae 
PR-URL: #25979
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @addaleax @danbev @targos @nodejs-github-bot